Check limit

See https://sqlite.org/forum/forumpost/0ea7672a43
This commit is contained in:
gwenn 2024-12-07 13:06:17 +01:00
parent c5c74e0d86
commit d80834bfe5

View File

@ -1,6 +1,6 @@
//! Run-Time Limits
use crate::{ffi, Connection};
use crate::{ffi, Connection, Error, Result};
use std::os::raw::c_int;
/// Run-Time limit categories, for use with [`Connection::limit`] and
@ -44,24 +44,47 @@ pub enum Limit {
/// The maximum number of auxiliary worker threads that a single prepared
/// statement may start.
SQLITE_LIMIT_WORKER_THREADS = ffi::SQLITE_LIMIT_WORKER_THREADS,
/// Only used for testing
#[cfg(test)]
INVALID = -1,
}
impl Connection {
/// Returns the current value of a [`Limit`].
#[inline]
#[cfg_attr(docsrs, doc(cfg(feature = "limits")))]
pub fn limit(&self, limit: Limit) -> i32 {
pub fn limit(&self, limit: Limit) -> Result<i32> {
let c = self.db.borrow();
unsafe { ffi::sqlite3_limit(c.db(), limit as c_int, -1) }
let rc = unsafe { ffi::sqlite3_limit(c.db(), limit as c_int, -1) };
if rc < 0 {
return Err(Error::SqliteFailure(
ffi::Error::new(ffi::SQLITE_RANGE),
Some(format!("{limit:?} is invalid")),
));
}
Ok(rc)
}
/// Changes the [`Limit`] to `new_val`, returning the prior
/// value of the limit.
#[inline]
#[cfg_attr(docsrs, doc(cfg(feature = "limits")))]
pub fn set_limit(&self, limit: Limit, new_val: i32) -> i32 {
pub fn set_limit(&self, limit: Limit, new_val: i32) -> Result<i32> {
if new_val < 0 {
return Err(Error::SqliteFailure(
ffi::Error::new(ffi::SQLITE_RANGE),
Some(format!("{new_val} is invalid")),
));
}
let c = self.db.borrow_mut();
unsafe { ffi::sqlite3_limit(c.db(), limit as c_int, new_val) }
let rc = unsafe { ffi::sqlite3_limit(c.db(), limit as c_int, new_val) };
if rc < 0 {
return Err(Error::SqliteFailure(
ffi::Error::new(ffi::SQLITE_RANGE),
Some(format!("{limit:?} is invalid")),
));
}
Ok(rc)
}
}
@ -106,12 +129,10 @@ mod test {
Limit::SQLITE_LIMIT_VARIABLE_NUMBER as i32,
ffi::SQLITE_LIMIT_VARIABLE_NUMBER,
);
#[cfg(feature = "bundled")]
assert_eq!(
Limit::SQLITE_LIMIT_TRIGGER_DEPTH as i32,
ffi::SQLITE_LIMIT_TRIGGER_DEPTH,
);
#[cfg(feature = "bundled")]
assert_eq!(
Limit::SQLITE_LIMIT_WORKER_THREADS as i32,
ffi::SQLITE_LIMIT_WORKER_THREADS,
@ -121,38 +142,44 @@ mod test {
#[test]
fn test_limit() -> Result<()> {
let db = Connection::open_in_memory()?;
db.set_limit(Limit::SQLITE_LIMIT_LENGTH, 1024);
assert_eq!(1024, db.limit(Limit::SQLITE_LIMIT_LENGTH));
db.set_limit(Limit::SQLITE_LIMIT_LENGTH, 1024)?;
assert_eq!(1024, db.limit(Limit::SQLITE_LIMIT_LENGTH)?);
db.set_limit(Limit::SQLITE_LIMIT_SQL_LENGTH, 1024);
assert_eq!(1024, db.limit(Limit::SQLITE_LIMIT_SQL_LENGTH));
db.set_limit(Limit::SQLITE_LIMIT_SQL_LENGTH, 1024)?;
assert_eq!(1024, db.limit(Limit::SQLITE_LIMIT_SQL_LENGTH)?);
db.set_limit(Limit::SQLITE_LIMIT_COLUMN, 64);
assert_eq!(64, db.limit(Limit::SQLITE_LIMIT_COLUMN));
db.set_limit(Limit::SQLITE_LIMIT_COLUMN, 64)?;
assert_eq!(64, db.limit(Limit::SQLITE_LIMIT_COLUMN)?);
db.set_limit(Limit::SQLITE_LIMIT_EXPR_DEPTH, 256);
assert_eq!(256, db.limit(Limit::SQLITE_LIMIT_EXPR_DEPTH));
db.set_limit(Limit::SQLITE_LIMIT_EXPR_DEPTH, 256)?;
assert_eq!(256, db.limit(Limit::SQLITE_LIMIT_EXPR_DEPTH)?);
db.set_limit(Limit::SQLITE_LIMIT_COMPOUND_SELECT, 32);
assert_eq!(32, db.limit(Limit::SQLITE_LIMIT_COMPOUND_SELECT));
db.set_limit(Limit::SQLITE_LIMIT_COMPOUND_SELECT, 32)?;
assert_eq!(32, db.limit(Limit::SQLITE_LIMIT_COMPOUND_SELECT)?);
db.set_limit(Limit::SQLITE_LIMIT_FUNCTION_ARG, 32);
assert_eq!(32, db.limit(Limit::SQLITE_LIMIT_FUNCTION_ARG));
db.set_limit(Limit::SQLITE_LIMIT_FUNCTION_ARG, 32)?;
assert_eq!(32, db.limit(Limit::SQLITE_LIMIT_FUNCTION_ARG)?);
db.set_limit(Limit::SQLITE_LIMIT_ATTACHED, 2);
assert_eq!(2, db.limit(Limit::SQLITE_LIMIT_ATTACHED));
db.set_limit(Limit::SQLITE_LIMIT_ATTACHED, 2)?;
assert_eq!(2, db.limit(Limit::SQLITE_LIMIT_ATTACHED)?);
db.set_limit(Limit::SQLITE_LIMIT_LIKE_PATTERN_LENGTH, 128);
assert_eq!(128, db.limit(Limit::SQLITE_LIMIT_LIKE_PATTERN_LENGTH));
db.set_limit(Limit::SQLITE_LIMIT_LIKE_PATTERN_LENGTH, 128)?;
assert_eq!(128, db.limit(Limit::SQLITE_LIMIT_LIKE_PATTERN_LENGTH)?);
db.set_limit(Limit::SQLITE_LIMIT_VARIABLE_NUMBER, 99);
assert_eq!(99, db.limit(Limit::SQLITE_LIMIT_VARIABLE_NUMBER));
db.set_limit(Limit::SQLITE_LIMIT_VARIABLE_NUMBER, 99)?;
assert_eq!(99, db.limit(Limit::SQLITE_LIMIT_VARIABLE_NUMBER)?);
db.set_limit(Limit::SQLITE_LIMIT_TRIGGER_DEPTH, 32);
assert_eq!(32, db.limit(Limit::SQLITE_LIMIT_TRIGGER_DEPTH));
db.set_limit(Limit::SQLITE_LIMIT_TRIGGER_DEPTH, 32)?;
assert_eq!(32, db.limit(Limit::SQLITE_LIMIT_TRIGGER_DEPTH)?);
db.set_limit(Limit::SQLITE_LIMIT_WORKER_THREADS, 2);
assert_eq!(2, db.limit(Limit::SQLITE_LIMIT_WORKER_THREADS));
db.set_limit(Limit::SQLITE_LIMIT_WORKER_THREADS, 2)?;
assert_eq!(2, db.limit(Limit::SQLITE_LIMIT_WORKER_THREADS)?);
assert!(db
.set_limit(Limit::SQLITE_LIMIT_WORKER_THREADS, -1)
.is_err());
assert!(db.set_limit(Limit::INVALID, 0).is_err());
assert!(db.limit(Limit::INVALID).is_err());
Ok(())
}
}