tianzixuan/gradle-build-action
1
0
Fork 0
mirror of https://github.com/gradle/gradle-build-action.git synced 2024-12-25 14:46:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove writing value to gradle.properties in setup

Browse Source 
The written property will override any project-level setting, which
can lead to confusing behaviour.

Fixes #1024
This commit is contained in:
daz 2024-01-03 18:49:57 -07:00
parent 32bab5b15a
commit 7c57ba1136
No known key found for this signature in database
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/cache-base.ts
View File

@ -189,21 +189,6 @@ export class GradleStateCache {
} }
private initializeGradleUserHome(gradleUserHome: string, initScriptsDir: string): void { private initializeGradleUserHome(gradleUserHome: string, initScriptsDir: string): void {
// Ensure that pre-installed java versions are detected. Only add property if it isn't already defined.
const gradleProperties = path.resolve(gradleUserHome, 'gradle.properties')
const existingGradleProperties = fs.existsSync(gradleProperties)
? fs.readFileSync(gradleProperties, 'utf8')
: ''
if (!existingGradleProperties.includes('org.gradle.java.installations.fromEnv=')) {
fs.appendFileSync(
gradleProperties,
`
# Auto-detect pre-installed JDKs
org.gradle.java.installations.fromEnv=JAVA_HOME_8_X64,JAVA_HOME_11_X64,JAVA_HOME_17_X64
`
)
}
// Copy init scripts from src/resources // Copy init scripts from src/resources
const initScriptFilenames = [ const initScriptFilenames = [
'gradle-build-action.build-result-capture.init.gradle', 'gradle-build-action.build-result-capture.init.gradle',