Feature/zpf (#564)

* iOS: fix memory leak of blur effect

* js: fix callback cause memory leak
This commit is contained in:
osborn
2022-12-20 15:06:46 +08:00
committed by GitHub
parent c60754c53d
commit be4fb05f91
13 changed files with 77 additions and 22 deletions

View File

@@ -7,6 +7,7 @@ export declare class Context {
callbacks: Map<string, {
resolve: Function;
reject: Function;
retained?: boolean;
}>;
classes: Map<string, ClassType<object>>;
hookBeforeNativeCall(): void;

View File

@@ -45,6 +45,9 @@ export function jsCallResolve(contextId, callbackId, args) {
}
hookBeforeNativeCall(context);
Reflect.apply(callback.resolve, context, argumentsList);
if (callback.retained !== true) {
context.callbacks.delete(callbackId);
}
}
export function jsCallReject(contextId, callbackId, args) {
const context = gContexts.get(contextId);
@@ -63,6 +66,9 @@ export function jsCallReject(contextId, callbackId, args) {
}
hookBeforeNativeCall(context);
Reflect.apply(callback.reject, context.entity, argumentsList);
if (callback.retained !== true) {
context.callbacks.delete(callbackId);
}
}
export class Context {
constructor(id) {
@@ -126,7 +132,8 @@ export class Context {
const functionId = uniqueId('function');
this.callbacks.set(functionId, {
resolve: func,
reject: () => { loge("This should not be called"); }
reject: () => { loge("This should not be called"); },
retained: true,
});
return functionId;
}