iOS: Ensure that rendering operations are serialized to prevent timing errors
This commit is contained in:
parent
5dd7504a37
commit
81137b8fb8
@ -109,7 +109,14 @@ - (id)findClass:(Class)clz target:(id)target context:(DoricContext *)context met
|
|||||||
const char *retType = methodSignature.methodReturnType;
|
const char *retType = methodSignature.methodReturnType;
|
||||||
if (!strcmp(retType, @encode(void))) {
|
if (!strcmp(retType, @encode(void))) {
|
||||||
ret = nil;
|
ret = nil;
|
||||||
|
DoricThreadMode mode = [target threadMode:methodName];
|
||||||
|
if (mode == DoricThreadModeUI) {
|
||||||
|
dispatch_async(dispatch_get_main_queue(), block);
|
||||||
|
} else if (mode == DoricThreadModeJS) {
|
||||||
|
block();
|
||||||
|
} else {
|
||||||
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), block);
|
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), block);
|
||||||
|
}
|
||||||
} else if (!strcmp(retType, @encode(id))) {
|
} else if (!strcmp(retType, @encode(id))) {
|
||||||
void *retValue;
|
void *retValue;
|
||||||
block();
|
block();
|
||||||
|
@ -25,10 +25,21 @@
|
|||||||
#import "DoricPromise.h"
|
#import "DoricPromise.h"
|
||||||
#import "DoricRegistry.h"
|
#import "DoricRegistry.h"
|
||||||
|
|
||||||
|
typedef NS_ENUM(NSUInteger, DoricThreadMode) {
|
||||||
|
DoricThreadModeUI = 1,
|
||||||
|
DoricThreadModeJS = 2,
|
||||||
|
DoricThreadModeIndependent = 3,
|
||||||
|
};
|
||||||
|
|
||||||
NS_ASSUME_NONNULL_BEGIN
|
NS_ASSUME_NONNULL_BEGIN
|
||||||
|
|
||||||
@interface DoricNativePlugin : DoricContextHolder
|
@interface DoricNativePlugin : DoricContextHolder
|
||||||
|
/**
|
||||||
|
* Determines which thread this method should run on
|
||||||
|
* @param method name of method
|
||||||
|
* @return thread where this method should run on,default is DoricThreadModeIndependent
|
||||||
|
* */
|
||||||
|
- (DoricThreadMode)threadMode:(NSString *)method;
|
||||||
@end
|
@end
|
||||||
|
|
||||||
NS_ASSUME_NONNULL_END
|
NS_ASSUME_NONNULL_END
|
||||||
|
@ -23,5 +23,7 @@
|
|||||||
#import "DoricNativePlugin.h"
|
#import "DoricNativePlugin.h"
|
||||||
|
|
||||||
@implementation DoricNativePlugin
|
@implementation DoricNativePlugin
|
||||||
|
- (DoricThreadMode)threadMode:(NSString *)method {
|
||||||
|
return DoricThreadModeIndependent;
|
||||||
|
}
|
||||||
@end
|
@end
|
||||||
|
@ -29,14 +29,15 @@
|
|||||||
|
|
||||||
@implementation DoricShaderPlugin
|
@implementation DoricShaderPlugin
|
||||||
|
|
||||||
|
- (DoricThreadMode)threadMode:(NSString *)method {
|
||||||
|
return DoricThreadModeUI;
|
||||||
|
}
|
||||||
|
|
||||||
- (void)render:(NSDictionary *)argument withPromise:(DoricPromise *)promise {
|
- (void)render:(NSDictionary *)argument withPromise:(DoricPromise *)promise {
|
||||||
if (!argument) {
|
if (!argument) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
[self.doricContext.performanceProfile prepare:@"Render"];
|
[self.doricContext.performanceProfile prepare:@"Render"];
|
||||||
__weak typeof(self) _self = self;
|
|
||||||
[self.doricContext dispatchToMainQueue:^{
|
|
||||||
__strong typeof(_self) self = _self;
|
|
||||||
if (self.doricContext == nil) {
|
if (self.doricContext == nil) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
@ -54,13 +55,9 @@ - (void)render:(NSDictionary *)argument withPromise:(DoricPromise *)promise {
|
|||||||
}
|
}
|
||||||
[promise resolve:nil];
|
[promise resolve:nil];
|
||||||
[self.doricContext.performanceProfile end:@"Render"];
|
[self.doricContext.performanceProfile end:@"Render"];
|
||||||
}];
|
|
||||||
}
|
}
|
||||||
|
|
||||||
- (void)command:(NSDictionary *)argument withPromise:(DoricPromise *)promise {
|
- (void)command:(NSDictionary *)argument withPromise:(DoricPromise *)promise {
|
||||||
__weak typeof(self) _self = self;
|
|
||||||
[self.doricContext dispatchToMainQueue:^{
|
|
||||||
__strong typeof(_self) self = _self;
|
|
||||||
if (self.doricContext == nil) {
|
if (self.doricContext == nil) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
@ -82,7 +79,6 @@ - (void)command:(NSDictionary *)argument withPromise:(DoricPromise *)promise {
|
|||||||
} else {
|
} else {
|
||||||
[self findClass:[viewNode class] target:viewNode method:name promise:promise argument:args];
|
[self findClass:[viewNode class] target:viewNode method:name promise:promise argument:args];
|
||||||
}
|
}
|
||||||
}];
|
|
||||||
}
|
}
|
||||||
|
|
||||||
- (id)createParamWithMethodName:(NSString *)method promise:(DoricPromise *)promise argument:(id)argument {
|
- (id)createParamWithMethodName:(NSString *)method promise:(DoricPromise *)promise argument:(id)argument {
|
||||||
|
Reference in New Issue
Block a user