Merge pull request #1293 from mhammond/no-panic-on-drop

No longer panic if we fail to close the connection when dropping it.
This commit is contained in:
gwenn 2023-02-24 08:51:25 +01:00 committed by GitHub
commit 929be82c9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -371,15 +371,7 @@ impl Drop for InnerConnection {
#[allow(unused_must_use)] #[allow(unused_must_use)]
#[inline] #[inline]
fn drop(&mut self) { fn drop(&mut self) {
use std::thread::panicking; self.close();
if let Err(e) = self.close() {
if panicking() {
eprintln!("Error while closing SQLite connection: {e:?}");
} else {
panic!("Error while closing SQLite connection: {:?}", e);
}
}
} }
} }