Add sanity check for insert that does not do an insertion

This commit is contained in:
John Gallagher
2016-05-16 11:15:07 -05:00
parent 504b16dc98
commit 7b174c97f8
2 changed files with 37 additions and 9 deletions

View File

@@ -57,7 +57,11 @@ pub enum Error {
InvalidColumnType,
/// Error when a query that was expected to insert one row did not insert any or insert many.
QueryInsertedRows(c_int),
StatementChangedRows(c_int),
/// Error when a query that was expected to insert a row did not change the connection's
/// last_insert_rowid().
StatementFailedToInsertRow,
/// Error returned by `functions::Context::get` when the function argument cannot be converted
/// to the requested type.
@@ -105,7 +109,8 @@ impl fmt::Display for Error {
Error::InvalidColumnIndex(i) => write!(f, "Invalid column index: {}", i),
Error::InvalidColumnName(ref name) => write!(f, "Invalid column name: {}", name),
Error::InvalidColumnType => write!(f, "Invalid column type"),
Error::QueryInsertedRows(i) => write!(f, "Query inserted {} rows", i),
Error::StatementChangedRows(i) => write!(f, "Query changed {} rows", i),
Error::StatementFailedToInsertRow => write!(f, "Statement failed to insert new row"),
#[cfg(feature = "functions")]
Error::InvalidFunctionParameterType => write!(f, "Invalid function parameter type"),
@@ -136,7 +141,8 @@ impl error::Error for Error {
Error::InvalidColumnIndex(_) => "invalid column index",
Error::InvalidColumnName(_) => "invalid column name",
Error::InvalidColumnType => "invalid column type",
Error::QueryInsertedRows(_) => "query inserted zero or more than one row",
Error::StatementChangedRows(_) => "query inserted zero or more than one row",
Error::StatementFailedToInsertRow => "statement failed to insert new row",
#[cfg(feature = "functions")]
Error::InvalidFunctionParameterType => "invalid function parameter type",
@@ -162,7 +168,8 @@ impl error::Error for Error {
Error::InvalidColumnName(_) |
Error::InvalidColumnType |
Error::InvalidPath(_) => None,
Error::QueryInsertedRows(_) => None,
Error::StatementChangedRows(_) => None,
Error::StatementFailedToInsertRow => None,
#[cfg(feature = "functions")]
Error::InvalidFunctionParameterType => None,