From 5e1e805b4ff2647ff555ade54af5232f7099dc4a Mon Sep 17 00:00:00 2001 From: gwenn Date: Sat, 28 Jul 2018 16:04:42 +0200 Subject: [PATCH] Use `sqlite3_get_autocommit` instead of our own flag/status --- src/transaction.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/transaction.rs b/src/transaction.rs index 104bac0..fb74fd4 100644 --- a/src/transaction.rs +++ b/src/transaction.rs @@ -61,7 +61,6 @@ pub type SqliteTransaction<'conn> = Transaction<'conn>; pub struct Transaction<'conn> { conn: &'conn Connection, drop_behavior: DropBehavior, - committed: bool, } /// Represents a savepoint on a database connection. @@ -111,7 +110,6 @@ impl<'conn> Transaction<'conn> { Transaction { conn, drop_behavior: DropBehavior::Rollback, - committed: false, } }) } @@ -168,7 +166,6 @@ impl<'conn> Transaction<'conn> { fn commit_(&mut self) -> Result<()> { self.conn.execute_batch("COMMIT")?; - self.committed = true; Ok(()) } @@ -179,7 +176,6 @@ impl<'conn> Transaction<'conn> { fn rollback_(&mut self) -> Result<()> { self.conn.execute_batch("ROLLBACK")?; - self.committed = true; Ok(()) } @@ -193,7 +189,7 @@ impl<'conn> Transaction<'conn> { } fn finish_(&mut self) -> Result<()> { - if self.committed { + if self.conn.is_autocommit() { return Ok(()); } match self.drop_behavior() {