From 5d8a840b5dc9114030bcfe44c29eb0b0e64697cb Mon Sep 17 00:00:00 2001 From: Travis Cross Date: Sun, 24 Dec 2017 09:02:40 +0000 Subject: [PATCH 1/3] Fix date/time format for SQLite, use RFC 3339 We implement `ToSql` and `FromSql` for `time::Timespec` values. Our documentation indicates that we store the value in the same format used by SQLite's built-in date/time functions, but this was not correct. We were using the format: %Y-%m-%d %H:%M:%S:%f %Z This format cannot be interpreted at all by SQLite's built-in date/time functions. There are three reasons for this: - SQLite supports only two timezone formats: `[+-]HH:MM` and the literal character `Z` (indicating UTC) - SQLite does not support a space before the timezone indicator - SQLite supports a period (`.`) between the seconds field and the fractional seconds field, but not a colon (`:`) SQLite does support the RFC 3339 date/time format, which is standard in many other places. As we're always storing a UTC value, we'll simply use a trailing `Z` to indicate the timezone, as allowed by RFC 3339. The new format is: %Y-%m-%dT%H:%M:%S.%fZ To avoid breaking applications using databases with values in the old format, we'll continue to support it as a fallback for `FromSql`. [1] https://www.sqlite.org/lang_datefunc.html [2] https://tools.ietf.org/html/rfc3339 --- src/types/mod.rs | 13 +++++++------ src/types/time.rs | 13 ++++++++----- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/src/types/mod.rs b/src/types/mod.rs index c998d89..74757cb 100644 --- a/src/types/mod.rs +++ b/src/types/mod.rs @@ -10,12 +10,13 @@ //! * Strings (`String` and `&str`) //! * Blobs (`Vec` and `&[u8]`) //! -//! Additionally, because it is such a common data type, implementations are provided for -//! `time::Timespec` that use a string for storage (using the same format string, -//! `"%Y-%m-%d %H:%M:%S"`, as SQLite's builtin -//! [datetime](https://www.sqlite.org/lang_datefunc.html) function. Note that this storage -//! truncates timespecs to the nearest second. If you want different storage for timespecs, you can -//! use a newtype. For example, to store timespecs as `f64`s: +//! Additionally, because it is such a common data type, implementations are +//! provided for `time::Timespec` that use the RFC 3339 date/time format, +//! `"%Y-%m-%dT%H:%M:%S.%fZ"`, to store time values as strings. These values +//! can be parsed by SQLite's builtin +//! [datetime](https://www.sqlite.org/lang_datefunc.html) functions. If you +//! want different storage for timespecs, you can use a newtype. For example, to +//! store timespecs as `f64`s: //! //! ```rust //! extern crate rusqlite; diff --git a/src/types/time.rs b/src/types/time.rs index f0dd46c..458435c 100644 --- a/src/types/time.rs +++ b/src/types/time.rs @@ -3,7 +3,8 @@ extern crate time; use Result; use types::{FromSql, FromSqlError, FromSqlResult, ToSql, ToSqlOutput, ValueRef}; -const SQLITE_DATETIME_FMT: &str = "%Y-%m-%d %H:%M:%S:%f %Z"; +const SQLITE_DATETIME_FMT: &str = "%Y-%m-%dT%H:%M:%S.%fZ"; +const SQLITE_DATETIME_FMT_LEGACY: &str = "%Y-%m-%d %H:%M:%S:%f %Z"; impl ToSql for time::Timespec { fn to_sql(&self) -> Result { @@ -19,10 +20,12 @@ impl FromSql for time::Timespec { fn column_result(value: ValueRef) -> FromSqlResult { value .as_str() - .and_then(|s| match time::strptime(s, SQLITE_DATETIME_FMT) { - Ok(tm) => Ok(tm.to_timespec()), - Err(err) => Err(FromSqlError::Other(Box::new(err))), - }) + .and_then(|s| { + time::strptime(s, SQLITE_DATETIME_FMT) + .or_else(|err| { + time::strptime(s, SQLITE_DATETIME_FMT_LEGACY) + .or(Err(FromSqlError::Other(Box::new(err))))})}) + .map(|tm| tm.to_timespec()) } } From 96e5cf2239fd6d13c875bcfbe081a684dab4e746 Mon Sep 17 00:00:00 2001 From: gwenn Date: Sat, 17 Feb 2018 10:11:39 +0100 Subject: [PATCH 2/3] Fix statement cache SQLite ignores the SQL tail (whitespaces, comments). We can easily ignore whitespaces by trimming the SQL. --- src/cache.rs | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/src/cache.rs b/src/cache.rs index bfafbac..d5bb5b4 100644 --- a/src/cache.rs +++ b/src/cache.rs @@ -46,6 +46,7 @@ impl Connection { self.cache.set_capacity(capacity) } + /// Remove/finalize all prepared statements currently in the cache. pub fn flush_prepared_statement_cache(&self) { self.cache.flush() } @@ -124,7 +125,7 @@ impl StatementCache { sql: &str) -> Result> { let mut cache = self.0.borrow_mut(); - let stmt = match cache.remove(sql) { + let stmt = match cache.remove(sql.trim()) { Some(raw_stmt) => Ok(Statement::new(conn, raw_stmt)), None => conn.prepare(sql), }; @@ -135,7 +136,7 @@ impl StatementCache { fn cache_stmt(&self, stmt: RawStatement) { let mut cache = self.0.borrow_mut(); stmt.clear_bindings(); - let sql = String::from_utf8_lossy(stmt.sql().to_bytes()).to_string(); + let sql = String::from_utf8_lossy(stmt.sql().to_bytes()).trim().to_string(); cache.insert(sql, stmt); } @@ -285,4 +286,27 @@ mod test { conn.close().expect("connection not closed"); } + + #[test] + fn test_cache_key() { + let db = Connection::open_in_memory().unwrap(); + let cache = &db.cache; + assert_eq!(0, cache.len()); + + //let sql = " PRAGMA schema_version; -- comment"; + let sql = "PRAGMA schema_version; "; + { + let mut stmt = db.prepare_cached(sql).unwrap(); + assert_eq!(0, cache.len()); + assert_eq!(0, stmt.query_row(&[], |r| r.get::(0)).unwrap()); + } + assert_eq!(1, cache.len()); + + { + let mut stmt = db.prepare_cached(sql).unwrap(); + assert_eq!(0, cache.len()); + assert_eq!(0, stmt.query_row(&[], |r| r.get::(0)).unwrap()); + } + assert_eq!(1, cache.len()); + } } From 7c4105afd9569fc86a45186573dc304519748eac Mon Sep 17 00:00:00 2001 From: gwenn Date: Fri, 6 Apr 2018 21:37:03 +0200 Subject: [PATCH 3/3] Upgrade dependencies bindgen from 0.32 to 0.35 lazy_static from 0.2 to 1.0 --- Cargo.toml | 2 +- libsqlite3-sys/Cargo.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 5199d0e..1c55343 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -38,7 +38,7 @@ serde_json = { version = "1.0", optional = true } [dev-dependencies] tempdir = "0.3" -lazy_static = "0.2" +lazy_static = "1.0" regex = "0.2" [dependencies.libsqlite3-sys] diff --git a/libsqlite3-sys/Cargo.toml b/libsqlite3-sys/Cargo.toml index 32d4d44..1127b7c 100644 --- a/libsqlite3-sys/Cargo.toml +++ b/libsqlite3-sys/Cargo.toml @@ -23,7 +23,7 @@ min_sqlite_version_3_7_4 = ["pkg-config", "vcpkg"] min_sqlite_version_3_7_16 = ["pkg-config", "vcpkg"] [build-dependencies] -bindgen = { version = "0.32", optional = true } +bindgen = { version = "0.35", optional = true } pkg-config = { version = "0.3", optional = true } cc = { version = "1.0", optional = true }