ISAR/libmdbx
3
0
Fork 0
mirror of https://github.com/isar/libmdbx.git synced 2025-11-04 05:08:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

mdbx: re-read and check meta-pages in mdbx_read_header() for consistency.

Browse Source
This commit is contained in:
Leo Yuriev
2017-05-26 18:10:23 +03:00
parent 93c5a84bcd
commit bd70135db1
1 changed files with 27 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/mdbx.c
View File

@@ -3290,11 +3290,33 @@ static int __cold mdbx_read_header(MDBX_env *env, MDBX_meta *meta) {
const unsigned meta_number = loop_count % NUM_METAS;
const unsigned offset = guess_pagesize * meta_number;
int rc = mdbx_pread(env->me_fd, &page, sizeof(page), offset);
if (rc != MDBX_SUCCESS) {
mdbx_error("read meta[%u,%u]: %i, %s", offset, (unsigned)sizeof(page), rc,
mdbx_strerror(rc));
return rc;
unsigned retryleft = 42;
while (1) {
int rc = mdbx_pread(env->me_fd, &page, sizeof(page), offset);
if (rc != MDBX_SUCCESS) {
mdbx_error("read meta[%u,%u]: %i, %s", offset, (unsigned)sizeof(page),
rc, mdbx_strerror(rc));
return rc;
}
MDBX_page again;
rc = mdbx_pread(env->me_fd, &again, sizeof(again), offset);
if (rc != MDBX_SUCCESS) {
mdbx_error("read meta[%u,%u]: %i, %s", offset, (unsigned)sizeof(again),
rc, mdbx_strerror(rc));
return rc;
}
if (memcmp(&page, &again, sizeof(page)) == 0 || --retryleft == 0)
break;
mdbx_info("meta[%u] was updated, re-read it", meta_number);
}
if (!retryleft) {
mdbx_error("meta[%u] is too volatile, skip it", meta_number);
continue;
}
if (page.mp_pgno != meta_number) {