ISAR/libmdbx
3
0
Fork 0
mirror of https://github.com/isar/libmdbx.git synced 2024-10-30 11:29:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

mdbx: minor fix mdbx_cursor_close().

Browse Source 
Avoids reference to txn which could be already freed.

Change-Id: I4e1fadd9786ced1533bb8468d30e013455601228
This commit is contained in:
Leonid Yuriev 2021-01-20 09:53:44 +03:00
parent 7d09de489d
commit 6bd0277020
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core.c
View File

@ -14940,14 +14940,13 @@ void mdbx_cursor_close(MDBX_cursor *mc) {
mdbx_ensure(NULL, mc->mc_signature == MDBX_MC_LIVE || mdbx_ensure(NULL, mc->mc_signature == MDBX_MC_LIVE ||
mc->mc_signature == MDBX_MC_READY4CLOSE); mc->mc_signature == MDBX_MC_READY4CLOSE);
MDBX_txn *const txn = mc->mc_txn; MDBX_txn *const txn = mc->mc_txn;
MDBX_env *const env = txn ? txn->mt_env : NULL;
if (!mc->mc_backup) { if (!mc->mc_backup) {
mc->mc_txn = NULL; mc->mc_txn = NULL;
/* Remove from txn, if tracked. /* Remove from txn, if tracked.
* A read-only txn (!C_UNTRACK) may have been freed already, * A read-only txn (!C_UNTRACK) may have been freed already,
* so do not peek inside it. Only write txns track cursors. */ * so do not peek inside it. Only write txns track cursors. */
if (mc->mc_flags & C_UNTRACK) { if (mc->mc_flags & C_UNTRACK) {
mdbx_ensure(env, check_txn_rw(txn, 0) == MDBX_SUCCESS); mdbx_ensure(txn->mt_env, check_txn_rw(txn, 0) == MDBX_SUCCESS);
MDBX_cursor **prev = &txn->tw.cursors[mc->mc_dbi]; MDBX_cursor **prev = &txn->tw.cursors[mc->mc_dbi];
while (*prev && *prev != mc) while (*prev && *prev != mc)
prev = &(*prev)->mc_next; prev = &(*prev)->mc_next;
@ -14960,7 +14959,7 @@ void mdbx_cursor_close(MDBX_cursor *mc) {
} else { } else {
/* Cursor closed before nested txn ends */ /* Cursor closed before nested txn ends */
mdbx_cassert(mc, mc->mc_signature == MDBX_MC_LIVE); mdbx_cassert(mc, mc->mc_signature == MDBX_MC_LIVE);
mdbx_ensure(env, check_txn_rw(txn, 0) == MDBX_SUCCESS); mdbx_ensure(txn->mt_env, check_txn_rw(txn, 0) == MDBX_SUCCESS);
mc->mc_signature = MDBX_MC_WAIT4EOT; mc->mc_signature = MDBX_MC_WAIT4EOT;
} }
} }