From 68a164da2b73ffcdd204a3a3503fa79d4f562581 Mon Sep 17 00:00:00 2001
From: Leonid Yuriev <leo@yuriev.ru>
Date: Thu, 17 Jun 2021 21:44:48 +0300
Subject: [PATCH] mdbx-test: add `mdbx_cursor_eof()` checking.

Related to https://github.com/erthink/libmdbx/issues/207.
---
 test/test.cc | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/test/test.cc b/test/test.cc
index 6852f420..eaf29e24 100644
--- a/test/test.cc
+++ b/test/test.cc
@@ -1018,7 +1018,7 @@ bool testcase::speculum_verify() {
   char dump_mkey[128], dump_mvalue[128];
 
   MDBX_cursor *cursor;
-  int err = mdbx_cursor_open(txn_guard.get(), dbi, &cursor);
+  int eof, err = mdbx_cursor_open(txn_guard.get(), dbi, &cursor);
   if (err != MDBX_SUCCESS)
     failure_perror("mdbx_cursor_open()", err);
 
@@ -1034,6 +1034,14 @@ bool testcase::speculum_verify() {
     if (err != MDBX_SUCCESS) {
       akey.iov_len = avalue.iov_len = 0;
       akey.iov_base = avalue.iov_base = nullptr;
+    } else {
+      eof = mdbx_cursor_eof(cursor);
+      if (eof != MDBX_RESULT_FALSE) {
+        log_error("false-positive cursor-eof %u/%u: db{%s, %s}, rc %i", n,
+                  extra, mdbx_dump_val(&akey, dump_key, sizeof(dump_key)),
+                  mdbx_dump_val(&avalue, dump_value, sizeof(dump_value)), eof);
+        rc = false;
+      }
     }
     const auto S_key = iov2dataview(akey);
     const auto S_data = iov2dataview(avalue);
@@ -1091,6 +1099,14 @@ bool testcase::speculum_verify() {
     n += 1;
   }
 
+  if (err == MDBX_NOTFOUND) {
+    eof = mdbx_cursor_eof(cursor);
+    if (eof != MDBX_RESULT_TRUE) {
+      eof = mdbx_cursor_eof(cursor);
+      log_error("false-negative cursor-eof: %u, rc %i", n, eof);
+      rc = false;
+    }
+  }
   mdbx_cursor_close(cursor);
   return rc;
 }