ISAR/libmdbx
3
0
Fork 0
mirror of https://github.com/isar/libmdbx.git synced 2025-10-31 03:29:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

mdbx: add a TODO/FIXME note (first r/w opening while r/o present).

Browse Source 
Change-Id: I5351628aa22313fffd6c2501a2aa16f2c5f573d5
This commit is contained in:
Leonid Yuriev
2021-03-30 01:38:24 +03:00
parent 4f62b059ef
commit 66df21ba78
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/core.c
View File

@@ -12101,8 +12101,20 @@ __cold int mdbx_env_open(MDBX_env *env, const char *pathname,
while (atomic_load32(&env->me_lck->mti_envmode, mo_AcquireRelease) ==
MDBX_RDONLY) {
if (atomic_cas32(&env->me_lck->mti_envmode, MDBX_RDONLY,
env->me_flags & mode_flags))
env->me_flags & mode_flags)) {
/* The case:
* - let's assume that for some reason the DB file is smaller
* than it should be according to the geometry,
* but not smaller than the last page used;
* - the first process that opens the database (lc_rc = true)
* does this in readonly mode and therefore cannot bring
* the file size back to normal;
* - some next process (lc_rc = false) opens the DB in read-write
* mode and now is here.
*
* FIXME: Should we re-check and set the size of DB-file right here? */
break;
}
atomic_yield();
}