ISAR/libmdbx
3
0
Fork 0
mirror of https://github.com/isar/libmdbx.git synced 2024-10-30 11:29:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

mdbx++: add FIXME for buffer::silo.

Browse Source 
Change-Id: I0a4a7bb947d019578153b7d09274b3ad0d1496aa
This commit is contained in:
Leonid Yuriev 2021-04-19 22:13:20 +03:00
parent 3a109cecdc
commit 62ccea031b
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mdbx.h++
View File

@ -803,6 +803,13 @@ protected:
/// \brief The chunk of data stored inside the buffer or located outside it.
template <class ALLOCATOR = legacy_allocator> class buffer {
friend class txn;
/* FIXME: replace std::string with custom silo.
* The std::string<char> does not guarantee any alignment for allocated
* buffer. For instance short values may be stored within internal inplace
* buffer, which might odd address. Moreover, allocator for the `char` type
* may return unaligned/odd address. This may UB for placing a 32-bit and
* 64-bit values.
* So seems the std::string<> should be replaced with ad hoc solution. */
using silo = ::mdbx::string<ALLOCATOR>;
silo silo_;
::mdbx::slice slice_;