ISAR/libmdbx
3
0
Fork 0
mirror of https://github.com/isar/libmdbx.git synced 2025-01-04 18:14:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

mdbx: fix/refine mdbx_find_largest().

Browse Source 
Change-Id: Ib40ca0014da18793be0bdae5133806304ad42819
This commit is contained in:
Leonid Yuriev 2019-07-09 02:46:24 +03:00
parent 421f4b01e6
commit 4ecf78163d
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/mdbx.c
View File

@ -2207,12 +2207,19 @@ static pgno_t mdbx_find_largest(MDBX_env *env, pgno_t largest) {
if (likely(lck != NULL /* exclusive mode */)) { if (likely(lck != NULL /* exclusive mode */)) {
const unsigned snap_nreaders = lck->mti_numreaders; const unsigned snap_nreaders = lck->mti_numreaders;
for (unsigned i = 0; i < snap_nreaders; ++i) { for (unsigned i = 0; i < snap_nreaders; ++i) {
retry:
if (lck->mti_readers[i].mr_pid) { if (lck->mti_readers[i].mr_pid) {
/* mdbx_jitter4testing(true); */ /* mdbx_jitter4testing(true); */
const pgno_t snap = lck->mti_readers[i].mr_snapshot_pages; const pgno_t snap_pages = lck->mti_readers[i].mr_snapshot_pages;
if (snap && snap >= largest && const txnid_t snap_txnid = lck->mti_readers[i].mr_txnid;
lck->mti_oldest >= lck->mti_readers[i].mr_txnid) mdbx_memory_barrier();
largest = snap; if (unlikely(snap_pages != lck->mti_readers[i].mr_snapshot_pages ||
snap_txnid != lck->mti_readers[i].mr_txnid))
goto retry;
if (largest < snap_pages &&
lck->mti_oldest <= /* ignore pending updates */ snap_txnid &&
snap_txnid <= env->me_txn0->mt_txnid)
largest = snap_pages;
} }
} }
} }