From 4703dac49dbaba52f99449d64535b18e24c941a7 Mon Sep 17 00:00:00 2001
From: Leonid Yuriev <leo@yuriev.ru>
Date: Mon, 19 Apr 2021 22:13:20 +0300
Subject: [PATCH] mdbx++: add FIXME for `buffer::silo`.

Change-Id: I0a4a7bb947d019578153b7d09274b3ad0d1496aa
---
 mdbx.h++ | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/mdbx.h++ b/mdbx.h++
index 7ae347c4..55e3d99d 100644
--- a/mdbx.h++
+++ b/mdbx.h++
@@ -803,6 +803,13 @@ protected:
 /// \brief The chunk of data stored inside the buffer or located outside it.
 template <class ALLOCATOR = legacy_allocator> class buffer {
   friend class txn;
+  /* FIXME: replace std::string with custom silo.
+   * The std::string<char> does not guarantee any alignment for allocated
+   * buffer. For instance short values may be stored within internal inplace
+   * buffer, which might odd address. Moreover, allocator for the `char` type
+   * may return unaligned/odd address. This may UB for placing a 32-bit and
+   * 64-bit values.
+   * So seems the std::string<> should be replaced with ad hoc solution. */
   using silo = ::mdbx::string<ALLOCATOR>;
   silo silo_;
   ::mdbx::slice slice_;