mdbx: устранение всех предупреждений статического анализатора MSVC (все несущественные или ложные).

test/chrono.c++

@@ -87,10 +87,11 @@ time from_ms(uint64_t ms) {
 time now_realtime() {
 #if defined(_WIN32) || defined(_WIN64) || defined(_WINDOWS)
   static void(WINAPI * query_time)(LPFILETIME);
-  if (!query_time) {
-    query_time = (void(WINAPI *)(LPFILETIME))GetProcAddress(
-        GetModuleHandle(TEXT("kernel32.dll")),
-        "GetSystemTimePreciseAsFileTime");
+  if (unlikely(!query_time)) {
+    HMODULE hModule = GetModuleHandle(TEXT("kernel32.dll"));
+    if (hModule)
+      query_time = (void(WINAPI *)(LPFILETIME))GetProcAddress(
+          hModule, "GetSystemTimePreciseAsFileTime");
     if (!query_time)
       query_time = GetSystemTimeAsFileTime;
   }

test/keygen.c++

@@ -227,7 +227,8 @@ void maker::setup(const config::actor_params_pod &actor, unsigned actor_id,
 
   (void)thread_number;
   mapping = actor.keygen;
-  salt = (actor.keygen.seed + actor_id) * UINT64_C(14653293970879851569);
+  salt =
+      (actor.keygen.seed + uint64_t(actor_id)) * UINT64_C(14653293970879851569);
 
   base = actor.serial_base();
 }
@@ -315,11 +316,12 @@ void __hot maker::mk_begin(const serial_t serial, const essentials &params,
   out.value.iov_len = std::max(unsigned(params.minlen), length(serial));
   const auto variation = params.maxlen - params.minlen;
   if (variation) {
-    if (serial % (variation + 1)) {
+    if (serial % (variation + serial_t(1))) {
       auto refix = serial * UINT64_C(48835288005252737);
       refix ^= refix >> 32;
-      out.value.iov_len = std::max(
-          out.value.iov_len, params.minlen + 1 + size_t(refix) % variation);
+      out.value.iov_len =
+          std::max(out.value.iov_len,
+                   params.minlen + size_t(1) + size_t(refix) % variation);
     }
   }
 

test/log.c++

@@ -142,7 +142,7 @@ void output_nocheckloglevel_ap(const logging::loglevel priority,
           prefix.c_str(), level2str(priority), suffix.c_str());
 
   va_list ones;
-  memset(&ones, 0, sizeof(ones)) /* zap MSVC and other stupid compilers */;
+  memset(&ones, 0, sizeof(ones)) /* zap MSVC and other goofy compilers */;
   if (same_or_higher(priority, error))
     va_copy(ones, ap);
   vfprintf(last, format, ap);
@@ -153,11 +153,11 @@ void output_nocheckloglevel_ap(const logging::loglevel priority,
   switch (end) {
   default:
     putc('\n', last);
-  // fall through
+    MDBX_CXX17_FALLTHROUGH; // fall through
   case '\n':
     fflush(last);
     last = nullptr;
-  // fall through
+    MDBX_CXX17_FALLTHROUGH; // fall through
   case ' ':
   case '_':
   case ':':

test/osal-windows.c++

@@ -248,7 +248,7 @@ Environment:
     CommandLine.push_back('"');
 
     for (auto It = Argument.begin();; ++It) {
-      unsigned NumberBackslashes = 0;
+      size_t NumberBackslashes = 0;
 
       while (It != Argument.end() && *It == '\\') {
         ++It;
@@ -435,7 +435,7 @@ void osal_udelay(size_t us) {
     unsigned timeslice_ms = 1;
     while (timeBeginPeriod(timeslice_ms) == TIMERR_NOCANDO)
       ++timeslice_ms;
-    threshold_us = timeslice_ms * 1500u;
+    threshold_us = timeslice_ms * size_t(1500);
     assert(threshold_us > 0);
   }
 

test/test.c++

@@ -100,7 +100,7 @@ int testcase::hsr_callback(const MDBX_env *env, const MDBX_txn *txn,
        info.mi_geo.current >= info.mi_geo.upper)) {
     osal_yield();
     if (retry > 0)
-      osal_udelay(retry * 100);
+      osal_udelay(retry * size_t(100));
     return MDBX_RESULT_FALSE /* retry / wait until reader done */;
   }
 

test/test.h++

@@ -101,10 +101,10 @@ class testcase;
 
 class registry {
   struct record {
-    actor_testcase id;
+    actor_testcase id = ac_none;
     std::string name;
-    bool (*review_params)(actor_params &);
-    testcase *(*constructor)(const actor_config &, const mdbx_pid_t);
+    bool (*review_params)(actor_params &) = nullptr;
+    testcase *(*constructor)(const actor_config &, const mdbx_pid_t) = nullptr;
   };
   std::unordered_map<std::string, const record *> name2id;
   std::unordered_map<int, const record *> id2record;