ISAR/libmdbx
3
0
Fork 0
mirror of https://github.com/isar/libmdbx.git synced 2024-10-30 23:39:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

mdbx: avoid on-stack allocation/chkstk inside mdbx_reader_check0().

Browse Source 
4 of 17 for https://github.com/leo-yuriev/libmdbx/issues/43

Change-Id: I31a8396ccc5db32cbd1816593861d2ee4325d09f
This commit is contained in:
Leonid Yuriev 2018-10-13 12:34:00 +03:00
parent 23d2f0fbb5
commit 180c605cac
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/mdbx.c
View File

@ -12427,7 +12427,14 @@ int __cold mdbx_reader_check0(MDBX_env *env, int rdt_locked, int *dead) {
} }
const unsigned snap_nreaders = lck->mti_numreaders; const unsigned snap_nreaders = lck->mti_numreaders;
mdbx_pid_t *pids = alloca((snap_nreaders + 1) * sizeof(mdbx_pid_t)); mdbx_pid_t pidsbuf_onstask[142];
mdbx_pid_t *const pids =
(snap_nreaders < ARRAY_LENGTH(pidsbuf_onstask))
? pidsbuf_onstask
: mdbx_malloc((snap_nreaders + 1) * sizeof(mdbx_pid_t));
if (unlikely(!pids))
return MDBX_ENOMEM;
pids[0] = 0; pids[0] = 0;
int rc = MDBX_SUCCESS, count = 0; int rc = MDBX_SUCCESS, count = 0;
@ -12493,6 +12500,9 @@ int __cold mdbx_reader_check0(MDBX_env *env, int rdt_locked, int *dead) {
if (rdt_locked < 0) if (rdt_locked < 0)
mdbx_rdt_unlock(env); mdbx_rdt_unlock(env);
if (pids != pidsbuf_onstask)
mdbx_free(pids);
if (dead) if (dead)
*dead = count; *dead = count;
return rc; return rc;