ISAR/libmdbx
3
0
Fork 0
mirror of https://github.com/isar/libmdbx.git synced 2025-01-04 17:24:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

mdbx: fix minor/potential mem-page leak inside mdbx_page_unspill().

Browse Source 
Change-Id: I4398a4d81eda494e4de9d62d81e3936c6357b744
This commit is contained in:
Leonid Yuriev 2020-12-20 16:08:57 +03:00
parent 21fbc36311
commit 05958a708e
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/core.c
View File

@ -5652,7 +5652,7 @@ static int __must_check_result mdbx_page_unspill(MDBX_txn *txn, MDBX_page *mp,
txn->tw.dirtylist->length); txn->tw.dirtylist->length);
return MDBX_TXN_FULL; return MDBX_TXN_FULL;
} }
unsigned num = IS_OVERFLOW(mp) ? mp->mp_pages : 1; const unsigned num = IS_OVERFLOW(mp) ? mp->mp_pages : 1;
MDBX_page *np = mp; MDBX_page *np = mp;
if ((env->me_flags & MDBX_WRITEMAP) == 0) { if ((env->me_flags & MDBX_WRITEMAP) == 0) {
np = mdbx_page_malloc(txn, num); np = mdbx_page_malloc(txn, num);
@ -5676,9 +5676,12 @@ static int __must_check_result mdbx_page_unspill(MDBX_txn *txn, MDBX_page *mp,
* page remains spilled until child commits */ * page remains spilled until child commits */
int rc = mdbx_page_dirty(txn, np); int rc = mdbx_page_dirty(txn, np);
if (likely(rc == MDBX_SUCCESS)) if (unlikely(rc != MDBX_SUCCESS)) {
*ret = np; if ((env->me_flags & MDBX_WRITEMAP) == 0)
return rc; mdbx_dpage_free(env, np, num);
return rc;
}
*ret = np;
} }
return MDBX_SUCCESS; return MDBX_SUCCESS;
} }